Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify application of HOMEBREW_ARTIFACT_DOMAIN #13227

Merged
merged 2 commits into from
May 23, 2022
Merged

docs: clarify application of HOMEBREW_ARTIFACT_DOMAIN #13227

merged 2 commits into from
May 23, 2022

Conversation

UiP9AV6Y
Copy link

@UiP9AV6Y UiP9AV6Y commented May 2, 2022

bottle URLs are treated differently than any other URL.
this change clarifies the resulting URLs in the manpage.

closes #13222

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@UiP9AV6Y
Copy link
Author

in addition to the docs update, i have also migrated the test cases from #13258

bottle URLs are treated differently than any other URL.
this change clarifies the resulting URLs in the manpage.

closes #13222
@MikeMcQuaid
Copy link
Member

Thanks again @UiP9AV6Y!

@MikeMcQuaid MikeMcQuaid enabled auto-merge May 23, 2022 11:30
@MikeMcQuaid MikeMcQuaid merged commit 7a79da2 into Homebrew:master May 23, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HOMEBREW_ARTIFACT_DOMAIN behaviour differs from documentation
2 participants