Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This is a quick follow-up to #13300 to fix another vendored gem bug. This one only appeared when running
brew livecheck
on a formula with ausing: :homebrew_curl
URL (e.g.,kim-api
), which exercises theaddressable
code inLivecheck#use_homebrew_curl?
:The
addressable
gem depends on thepublic_suffix
gem and we also need to vendor thedata
dir frompublic_suffix
foraddressable
to function correctly. This PR updates.gitignore
and checks in thepublic_suffix-*/data
directory.Since
public_suffix
is only a dependency ofaddressable
(we're not using is directly), do we need to add it to theGemfile
or is this fine as-is?