Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/rubocops/patches: silence CodeQL alerts #13307

Merged
merged 1 commit into from
May 20, 2022

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented May 20, 2022

Fixes https://github.com/Homebrew/brew/security/code-scanning/2 (2).
Fixes https://github.com/Homebrew/brew/security/code-scanning/3 (3).
Fixes https://github.com/Homebrew/brew/security/code-scanning/4 (4).
Fixes https://github.com/Homebrew/brew/security/code-scanning/5 (5).

These are tests, and the inputs are controlled by a fixed array in the same file, so this is not a security issue or even a possible bug. Nevertheless, silencing those alerts is trivial here.

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label May 20, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 merged commit cea550b into Homebrew:master May 20, 2022
@Bo98 Bo98 deleted the patches_spec-codeql branch May 20, 2022 18:14
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants