Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple authentication information from HOMEBREW_ARTIFACT_DOMAIN #13313

Merged
merged 1 commit into from
May 23, 2022
Merged

decouple authentication information from HOMEBREW_ARTIFACT_DOMAIN #13313

merged 1 commit into from
May 23, 2022

Conversation

UiP9AV6Y
Copy link

@UiP9AV6Y UiP9AV6Y commented May 23, 2022

add support for credentials usage in combination with other mirroring
features. previously HOMEBREW_DOCKER_REGISTRY_TOKEN and
HOMEBREW_DOCKER_REGISTRY_BASIC_AUTH_TOKEN where only used in combination
with HOMEBREW_ARTIFACT_DOMAIN which affects all curl download strategies.
HOMEBREW_BOTTLE_DOMAIN is only used for bottle artifacts, whose mirror might
also require credentials.
this change removes the requirement of using HOMEBREW_ARTIFACT_DOMAIN.

related to #13226

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

add support for credentials usage in combination with other mirroring
features. previously `HOMEBREW_DOCKER_REGISTRY_TOKEN` and
`HOMEBREW_DOCKER_REGISTRY_BASIC_AUTH_TOKEN` where only used in combination
with `HOMEBREW_ARTIFACT_DOMAIN` which affects *all* curl download strategies.
`HOMEBREW_BOTTLE_DOMAIN` is only used for bottle artifacts, whose mirror might
also require credentials.
this change removes the requirement of using `HOMEBREW_ARTIFACT_DOMAIN`.

related to #13226
@MikeMcQuaid MikeMcQuaid merged commit 0667aa6 into Homebrew:master May 23, 2022
@MikeMcQuaid
Copy link
Member

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @UiP9AV6Y!

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants