utils/github: take last artifact rather than first #13321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
May 24, 2022
dawidd6
approved these changes
May 24, 2022
|
Makes sense thanks @Bo98. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue where a CI run contained multiple artifacts of the same name: https://github.com/Homebrew/homebrew-core/actions/runs/2352886523
This is the first time I've ever seen it happen, so the issue is perhaps very rare or was the result of a temporary issue, but in such cases I believe taking the last artifact is more correct than taking the first, given the last one should have a higher ID number and thus have been created most recently.