Fix detect_clang_version version extraction

[imrehorvath]

The current pattern matching /clang-(\d+\.\d+\.\d+(\.\d+)?)/, 1 in the detect_clang_version method fails to fully match the new clang version string "1316.0.21.2.5" introduced with CLT 13.4, which lead to a false report of outdated CLT.

With this rewritten regex /clang-(\d+(\.\d+)+)/, 1, we have a more robust pattern matching enabled.

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[imrehorvath]

% /Library/Developer/CommandLineTools/usr/bin/clang --version
Apple clang version 13.1.6 (clang-1316.0.21.2.5)
Target: x86_64-apple-darwin21.5.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

irb(main):001:0> MacOS::CLT.outdated?
=> true
irb(main):002:0> MacOS::CLT.detect_clang_version
=> "1316.0.21.2"
irb(main):003:0> MacOS::CLT.latest_clang_version
=> "1316.0.21.2.5"

irb(main):009:0> Utils.popen_read("/Library/Developer/CommandLineTools/usr/bin/clang", "--version")[/clang-(\d+(\.\d+)+)/, 1]
=> "1316.0.21.2.5"
irb(main):010:0> Utils.popen_read("/Library/Developer/CommandLineTools/usr/bin/clang", "--version")[/clang-(\d+(\.\d+)+)/, 1].sub(/^(\d+)0(\d)\./, "\\1.\\2.")
=> "1316.0.21.2.5"
irb(main):011:0> 

[carlocab]

Thanks!