Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exceptions: fix did_you_mean error in some scenarios #13365

Merged
merged 1 commit into from
Jun 2, 2022
Merged

exceptions: fix did_you_mean error in some scenarios #13365

merged 1 commit into from
Jun 2, 2022

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Jun 2, 2022

Discovered while testing a release workflow for Homebrew/portable-ruby.

 /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/exceptions.rb:98:in `did_you_mean': undefined method `fuzzy_search' for Formula:Class (NoMethodError)
	from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/exceptions.rb:142:in `to_s'
	from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:168:in `message'
	from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:168:in `rescue in <main>'
	from /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:145:in `<main>'

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Jun 2, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit f00123a into Homebrew:master Jun 2, 2022
@MikeMcQuaid
Copy link
Member

Thanks @Bo98!

@Bo98 Bo98 deleted the exceptions-did_you_mean-fix branch June 2, 2022 11:33
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bo98 @BrewTestBot @MikeMcQuaid