Added support for running services fully backgrounded on macOS #13510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
reviewed
Jul 5, 2022
| # necessarily if it should run in a specific session type. Like database services could run with ProcessType | ||
| # Interactive so they have no resource limitations enforced upon them, but they aren't really interactive in the | ||
| # general sense. | ||
| base[:LimitLoadToSessionType] = %w[Aqua Background LoginWindow StandardIO System] |
There was a problem hiding this comment.
Should StandardIO and System be here too? In what situation would those be applicable?
There was a problem hiding this comment.
Well I noticed in lib/service/system.rb that you may also return the system domain instead of a user one. So the System type would enable you to keep using that.
As for StandardIO: that should be used if you run something without even a GUI session being available somewhere. Like logging in to an Aqua session and then starting a service through SSH would give Background, but rebooting your Mac and SSHing in before even logging in to Aqua should give you StandardIO. It might be an old flag though because in my tests I always got Background and never StandardIO.
MikeMcQuaid
requested changes
Jul 7, 2022
MikeMcQuaid
approved these changes
Jul 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This is the second part of a two-part contribution, with the first one being here. All the important info can be found there too. =] The existing automated tests should already cover the changes, although I did have to update the
expect()stuff.