Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make formulae with
on_{system}
blocks easier to read, we'd like to keep patches and resources where they're supposed to go (i.e. below dependencies) even if they are only present on some system configurations. However, since only one of eachon_{system}
block is allowed, we need to next theon_{system}
block within thepatch
orresource
block as is done in this example:When the condition isn't met (in this example when
MacOS.version < :high_sierra
), this is the same as an emptypatch do; end
block which is not currently allowed. This PR changes the login ofSoftwareSpec#patch
to ignore any external patches that don't define a URL.This was originally done in #13539 but needed to be extracted.