Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on_{system} methods to formula cookbook #13645

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Add on_{system} methods to formula cookbook #13645

merged 3 commits into from
Aug 5, 2022

Conversation

Rylan12
Copy link
Member

@Rylan12 Rylan12 commented Aug 4, 2022

Now that we require the use of on_{system} blocks in homebrew/core, we should document them. This PR adds a section to the formula cookbook with information on how to use the on_{system} blocks and also how to use if statements to check the same conditions inside def install and test do

@Rylan12 Rylan12 added the documentation Documentation changes label Aug 4, 2022
@BrewTestBot
Copy link
Member

Review period will end on 2022-08-05 at 00:35:42 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 4, 2022
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Copy link
Contributor

@gromgit gromgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of fixes and a tightening of prose.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 5, 2022
@BrewTestBot
Copy link
Member

Review period ended.

@Rylan12 Rylan12 merged commit 8fea5ed into Homebrew:master Aug 5, 2022
@Rylan12 Rylan12 deleted the on-system-docs branch August 5, 2022 14:05
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation changes outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants