Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LINUX_PREFERRED_GCC_FORMULA: Bump to gcc@11 #13752

Closed
wants to merge 2 commits into from

Conversation

sjackman
Copy link
Contributor

@sjackman sjackman commented Aug 24, 2022

Change LINUX_PREFERRED_GCC_FORMULA from gcc@5 to gcc@11.

Similarly to how we bumped the brewed Glibc version before building bottles with that Glibc version, perhaps we can also bump the preferred brewed GCC version before building bottles with that GCC version.

See #13619 (comment)

I'd like to have a stable release of Homebrew 3.6.0 that migrates our users to glibc 2.35 and gcc@11 before we move our bottling infrastructure to Ubuntu 22.04.

This PR needs to be merged and Homebrew 3.6.0 tagged simultaneously with merging PR Homebrew/homebrew-core#108816


  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Change `LINUX_PREFERRED_GCC_FORMULA` from `gcc@5` to `gcc@11`.
@sjackman sjackman self-assigned this Aug 24, 2022
@BrewTestBot
Copy link
Member

Review period will end on 2022-08-25 at 21:11:57 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 24, 2022
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to have a stable release of Homebrew 3.6.0 that migrates our users to glibc 2.35 and gcc@11 before we move our bottling infrastructure to Ubuntu 22.04.

Can you explain why? I have a pretty strong preference to land this Ubuntu 22.04 migration at the same time as we change our CI over (which will all be when 3.6.0 is tagged).

This PR needs to be merged and Homebrew 3.6.0 tagged simultaneously with merging PR Homebrew/homebrew-core#108816

👍🏻

Comment on lines -51 to -56
LINUX_PREFERRED_GCC_FORMULA = "gcc@5"
LINUX_PREFERRED_GCC_FORMULA = "gcc@11"

# Ubuntu 22.04 (see Linux-CI.md)
LINUX_GLIBC_NEXT_CI_VERSION = "2.35"
# LINUX_GCC_CI_VERSION = "11.0"
# LINUX_PREFERRED_GCC_FORMULA = "gcc@11"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't feel like the right move to me.

@sjackman
Copy link
Contributor Author

Closing in favour of PR

@sjackman sjackman closed this Aug 25, 2022
@sjackman sjackman deleted the sj/preferred_gcc branch August 25, 2022 19:36
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Aug 25, 2022
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants