-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LINUX_PREFERRED_GCC_FORMULA: Bump to gcc@11 #13752
Conversation
Change `LINUX_PREFERRED_GCC_FORMULA` from `gcc@5` to `gcc@11`.
Review period will end on 2022-08-25 at 21:11:57 UTC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have a stable release of Homebrew 3.6.0 that migrates our users to glibc 2.35 and gcc@11 before we move our bottling infrastructure to Ubuntu 22.04.
Can you explain why? I have a pretty strong preference to land this Ubuntu 22.04 migration at the same time as we change our CI over (which will all be when 3.6.0 is tagged).
This PR needs to be merged and Homebrew 3.6.0 tagged simultaneously with merging PR Homebrew/homebrew-core#108816
👍🏻
LINUX_PREFERRED_GCC_FORMULA = "gcc@5" | ||
LINUX_PREFERRED_GCC_FORMULA = "gcc@11" | ||
|
||
# Ubuntu 22.04 (see Linux-CI.md) | ||
LINUX_GLIBC_NEXT_CI_VERSION = "2.35" | ||
# LINUX_GCC_CI_VERSION = "11.0" | ||
# LINUX_PREFERRED_GCC_FORMULA = "gcc@11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't feel like the right move to me.
Closing in favour of PR |
Change
LINUX_PREFERRED_GCC_FORMULA
fromgcc@5
togcc@11
.See #13619 (comment)
I'd like to have a stable release of Homebrew 3.6.0 that migrates our users to
glibc
2.35 andgcc@11
before we move our bottling infrastructure to Ubuntu 22.04.This PR needs to be merged and Homebrew 3.6.0 tagged simultaneously with merging PR Homebrew/homebrew-core#108816
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?