Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Cask: automatically add cask audits" #13813

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Revert "Cask: automatically add cask audits" #13813

merged 1 commit into from
Sep 6, 2022

Conversation

MikeMcQuaid
Copy link
Member

Reverts #13746

CI is broken consistently on master and in PRs.

@BrewTestBot
Copy link
Member

Review period will end on 2022-09-07 at 10:46:56 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 6, 2022
@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Sep 6, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 6, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

SMillerDev
SMillerDev approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try again later without the types. Clearly brew typecheck checks are missing some cases here.

@MikeMcQuaid MikeMcQuaid merged commit ed916a5 into master Sep 6, 2022
@MikeMcQuaid MikeMcQuaid deleted the revert-13746-chore/cask/cleanup_audit branch September 6, 2022 11:12
This was referenced Sep 6, 2022
Merged
Merged
@SMillerDev SMillerDev mentioned this pull request Sep 13, 2022
Merged
7 tasks
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SMillerDev SMillerDev SMillerDev approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@reitermarkus reitermarkus Awaiting requested review from reitermarkus

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @BrewTestBot @SMillerDev