Allow developers to use dev commands and HOMEBREW_INSTALL_FROM_API
#13815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Review period will end on 2022-09-07 at 17:05:00 UTC. |
BrewTestBot
added
the
waiting for feedback
MikeMcQuaid
approved these changes
Sep 7, 2022
MikeMcQuaid
added
the
critical
|
Thanks again @Rylan12! |
BrewTestBot
removed
the
waiting for feedback
|
Review period skipped due to |
BrewTestBot
approved these changes
Sep 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #13794
This PR updates
brew.rbso that users who have setHOMEBREW_DEVELOPERandHOMEBREW_INSTALL_FROM_APIare allowed to run any developer command. This restriction was originally put in place to combat users trying to run commands that required homebrew/core to be installed without it installed (or with a super old version). However, now thatbrew updatewill keep homebrew/core up to date for developers, I think it's safe to remove for these people.