Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/artifact/relocated: widen type #13841

Merged
merged 1 commit into from
Sep 10, 2022
Merged

cask/artifact/relocated: widen type #13841

merged 1 commit into from
Sep 10, 2022

Conversation

jonchang
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes the bug:

% brew readall --eval-all homebrew/cask
Error: Invalid cask: /opt/homebrew/Library/Taps/homebrew/homebrew-cask/Casks/touchosc-editor.rb
Cask 'touchosc-editor' definition is invalid: invalid 'artifact' stanza: Parameter 'target': Expected type String, got type Pathname with value #<Pathname:/Users/jonchang/...upport/TouchOSCEditor/layouts>
Caller: /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10175/lib/types/private/methods/call_validation.rb:117
Definition: /opt/homebrew/Library/Homebrew/cask/artifact/relocated.rb:48
Error: Invalid cask: /opt/homebrew/Library/Taps/homebrew/homebrew-cask/Casks/ilya-birman-typography-layout.rb
Cask 'ilya-birman-typography-layout' definition is invalid: invalid 'artifact' stanza: Parameter 'target': Expected type String, got type Pathname with value #<Pathname:/Users/jonchang/...rman Typography Layout.bundle>
Caller: /opt/homebrew/Library/Homebrew/vendor/bundle/ruby/2.6.0/gems/sorbet-runtime-0.5.10175/lib/types/private/methods/call_validation.rb:117
Definition: /opt/homebrew/Library/Homebrew/cask/artifact/relocated.rb:48

@BrewTestBot
Copy link
Member

Review period will end on 2022-09-13 at 00:00:00 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 10, 2022
@Bo98 Bo98 added cask Homebrew Cask critical Critical change which should be shipped as soon as possible. labels Sep 10, 2022
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Sep 10, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 enabled auto-merge September 10, 2022 19:00
@Bo98 Bo98 merged commit 6e2b162 into Homebrew:master Sep 10, 2022
@jonchang jonchang deleted the sorbet-pathname branch September 10, 2022 19:49
@github-actions github-actions bot added the outdated PR was locked due to age label Oct 11, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cask Homebrew Cask critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants