Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out path args deprecation #14295

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Comment out path args deprecation #14295

merged 1 commit into from
Dec 28, 2022

Conversation

apainintheneck
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This comments out the deprecations added in #14285 so that they can be enabled when we put out another minor or major release.

@BrewTestBot
Copy link
Member

Review period will end on 2022-12-28 at 22:12:17 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 27, 2022
@apainintheneck apainintheneck mentioned this pull request Dec 27, 2022
Merged
7 tasks
@apainintheneck apainintheneck added the critical Critical change which should be shipped as soon as possible. label Dec 28, 2022
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Dec 28, 2022
@apainintheneck
Copy link
Contributor Author

This was also causing the brew bump-cask-pr and brew bump-formula-pr commands to fail as mentioned in #14296 so I decided to skip review.

@apainintheneck apainintheneck merged commit bbc475f into Homebrew:master Dec 28, 2022
@apainintheneck apainintheneck mentioned this pull request Dec 28, 2022
Merged
7 tasks
@MikeMcQuaid
Copy link
Member

Thanks @apainintheneck!

@apainintheneck apainintheneck deleted the comment-out-path-args-deprecation branch January 3, 2023 00:29
@github-actions github-actions bot added the outdated PR was locked due to age label Feb 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apainintheneck @BrewTestBot @MikeMcQuaid