Remove bitdefender diagnostic check #14300
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This check was added in four years ago in #5614. We were seeing problems at the time with users not being able to download packages correctly when running BitDefender (#4579 and #5558).
Those issues were apparently resolved by BitDefender and we got an issue in mid 2020 asking us to remove the check since it was no longer necessary (#7452). Since that point we haven't received anymore issues or complaints related to BitDefender in either the main
brew
repo or in the discussions (I just searched forbitdefender
in both places).Also, anecdotally, I haven't had any problems using
brew
andBitDefender
at the same time on my local system.CC: @MikeMcQuaid since you added the check and were involved in previous discussions.