Use JSON instead of #inspect
to include cask container in API
#14303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the cask JSON API's
container
entry to be actual JSON instead of just a ruby#inspect
string.Before:
After:
This is technically a breaking API change, but I can't imagine anyone is using the current system since it's in this weird format. If we get a complaint, we can revert. I'm marking this as
critical
since it is blocking the next step in the API project (loading casks directly from the API).