Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew.sh: add bump to HOMEBREW_NO_INSTALL_FROM_API commands #14536

Merged
merged 1 commit into from
Feb 7, 2023
Merged

brew.sh: add bump to HOMEBREW_NO_INSTALL_FROM_API commands #14536

merged 1 commit into from
Feb 7, 2023

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Feb 7, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew bump relies on livecheck, which we don't want to query the API
for.

Also, some small refactoring:

  1. Declare the list of commands we want to set
    HOMEBREW_NO_INSTALL_FROM_API for as an array.
  2. Only check against this list when the command being run is a
    developer command, to avoid checking the list when we know we're not
    running a dev command.

`brew bump` relies on `livecheck`, which we don't want to query the API
for.

Also, some small refactoring:

1. Declare the list of commands we want to set
   `HOMEBREW_NO_INSTALL_FROM_API` for as an array.
2. Only check against this list when the command being run is a
   developer command, to avoid checking the list when we know we're not
   running a dev command.
@BrewTestBot
Copy link
Member

Review period will end on 2023-02-08 at 06:38:11 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 7, 2023
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@Rylan12 Rylan12 added the critical Critical change which should be shipped as soon as possible. label Feb 7, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 7, 2023
@Rylan12 Rylan12 enabled auto-merge February 7, 2023 08:03
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Rylan12 Rylan12 merged commit 8fdf6ac into Homebrew:master Feb 7, 2023
@MikeMcQuaid
Copy link
Member

Thanks @carlocab!

  • Declare the list of commands we want to set
    HOMEBREW_NO_INSTALL_FROM_API for as an array.

Good idea! May want to do the same for https://github.com/carlocab/brew/blob/76466f66d26ef721186fcf2b555616db979f2861/Library/Homebrew/brew.sh#L240

@carlocab
Copy link
Member Author

carlocab commented Feb 7, 2023

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants