Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for 4.0.0 #14553

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Changes for 4.0.0 #14553

merged 2 commits into from
Feb 8, 2023

Conversation

MikeMcQuaid
Copy link
Member

When we're ready for the next branch to be 4.0.0:

  • re-enable HOMEBREW_INSTALL_FROM_API as the default
  • re-apply the deprecations

@MikeMcQuaid
Revert "Merge pull request #14547 from Homebrew/revert-14412-homebrew…
2a5d41d 
…_install_from_api_default"

This reverts commit f4e6048, reversing
changes made to e26784f.
@MikeMcQuaid
Revert "Merge pull request #14548 from Homebrew/revert-14382-deprecat…
6b43630 
…e-disable-remove"

This reverts commit 932d2cf, reversing
changes made to f4e6048.
@MikeMcQuaid MikeMcQuaid added do not merge critical Critical change which should be shipped as soon as possible. labels Feb 7, 2023
BrewTestBot
BrewTestBot previously approved these changes Feb 7, 2023
View reviewed changes
Rylan12
Rylan12 approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@Rylan12 Rylan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@MikeMcQuaid MikeMcQuaid enabled auto-merge February 8, 2023 11:03
@MikeMcQuaid MikeMcQuaid removed the critical Critical change which should be shipped as soon as possible. label Feb 8, 2023
@BrewTestBot BrewTestBot dismissed their stale review February 8, 2023 11:04

Review period has not ended yet.

@BrewTestBot
Copy link
Member

Review period will end on 2023-02-08 at 18:26:59 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 8, 2023
@MikeMcQuaid MikeMcQuaid added critical Critical change which should be shipped as soon as possible. and removed waiting for feedback Merging is blocked until sufficient time has passed for review labels Feb 8, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@MikeMcQuaid MikeMcQuaid merged commit cb1872e into Homebrew:master Feb 8, 2023
@MikeMcQuaid MikeMcQuaid deleted the 4.0.0-changes branch February 8, 2023 11:05
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

@Rylan12 Rylan12 Rylan12 approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MikeMcQuaid @BrewTestBot @Rylan12