Fix brew info --json regressions around install status
#14609
Conversation
Bo98
added
the
critical
|
Review period skipped due to |
There was a problem hiding this comment.
Are we sure that the API is necessary when printing the info for formulae? The original issue (#14541) only referenced problems related to cask info generation. It could have been broken before that though or there may have been another issue I missed as well.
Also, it'd be really nice if there was a small regression test that we could add so this sort of thing doesn't happen again.
| # TODO: can we implement these in Formulary? | ||
| if self.class.loaded_from_api && Homebrew::EnvConfig.install_from_api? | ||
| json_formula = Homebrew::API::Formula.all_formulae[name] | ||
| json_formula = Homebrew::API.merge_variations(json_formula) | ||
| hsh["oldname"] = json_formula["oldname"] | ||
| hsh["requirements"] = json_formula["requirements"] | ||
| end |
There was a problem hiding this comment.
Were these things missing even before the most recent regression?
There was a problem hiding this comment.
Yes. I hand tested by comparing with and without HOMEBREW_NO_INSTALL_FROM_API. See qt@5 as an example.
We do not currently read requirements or oldname from the JSON file. This will be fixed after 4.0.0 - I don't think people would be happy if I tried to get something larger before 4.0.0. 😅
Variations also don't work without the original source, hence why that has the hybrid of API + local.
#14587 unfortunately introduced some notable regressions to
brew info --json:outdatedboolean (very popularly used in scripts)."token"was missing from casks and"name"was missing from formulae.This PR fixes this by:
Formula#to_hashto instead take from the local state (our Formulary work means this works fine), except foroldnameandrequirements. In a future 4.0.x release, this will likely go away in favour of reading that data on the Formulary side. I'll make a PR after 4.0.0 with that - I'm keeping this PR as low risk as possible by only touching the broken functions.Formula#to_hash_with_variationto take both the local hash and API hash and take the relevant bits from both.Fixes #14600.