Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

formula: fix to_hash tampering with requirement names #14618

Merged
merged 1 commit into from
Feb 14, 2023
Merged

formula: fix to_hash tampering with requirement names #14618

merged 1 commit into from
Feb 14, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Feb 14, 2023

Very simple and obvious fix for https://formulae.brew.sh/formula/gcc@5 outputting a requirement of:

Maximum_maximum_maximum_maximum_maximum_maximum_maximum_maximum_maximum_maximum_maximum_maximum_maximum_macos <= 10.13 (build)

@Bo98 Bo98 added the critical Critical change which should be shipped as soon as possible. label Feb 14, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

@Bo98 Bo98 added the install from api Relates to API installs label Feb 14, 2023
@MikeMcQuaid MikeMcQuaid merged commit 8aa495b into Homebrew:master Feb 14, 2023
@MikeMcQuaid
Copy link
Member

Ok this is probably my favourite bug of the week.

Thanks @Bo98!

@Bo98 Bo98 deleted the maximum-req-name-fix branch February 14, 2023 13:00
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. install from api Relates to API installs outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bo98 @BrewTestBot @MikeMcQuaid