formulary: fix uses_from_macos handling on macOS #14621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bo98
added
the
critical
|
Review period skipped due to |
BrewTestBot
approved these changes
Feb 14, 2023
MikeMcQuaid
approved these changes
Feb 14, 2023
|
Thanks again @Bo98! |
Rylan12
reviewed
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially thought #14535 to be a weird thing with the Cocoapods formula, but it actually has far greater scope than anticipated. Even with the
on_armstuff removed, any macOS prior tosincestill didn't work properly.The cause was our dependency deduplication going on here. There is nothing to deduplicate on macOS however (
uses_from_macosis no-op and we don't passsinceas we do variations instead) so the fix is trivial: don't try to deduplicate on macOS!Test included.
Fixes #14535.