Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop: Entirely disable Metrics cops #14739

Merged
merged 1 commit into from
Feb 21, 2023
Merged

rubocop: Entirely disable Metrics cops #14739

merged 1 commit into from
Feb 21, 2023

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Feb 21, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Part of Remove usage of Exclude with rubocop #14685.
  • These are arbitrary length limits that had a load of disables in code.
  • The limits were only increasing over time rather than decreasing.
  • Fixing the problematic code to be shorter would take a long time for questionable gain since the problem has been around so long.

@issyl0
rubocop: Entirely disable Metrics cops
298bb65 
- These are arbitrary length limits that had a load of disables in code.
- The limits were only increasing over time rather than decreasing.
- Fixing the problematic code to be shorter would take a long time for
  questionable gain since the problem has been around so long.
@BrewTestBot
Copy link
Member

Review period will end on 2023-02-22 at 00:36:11 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 21, 2023
@samford
Copy link
Member

samford commented Feb 21, 2023 •
edited
Loading

As you've seen, I've certainly done battle with the Metrics cops in the past in livecheck, ahah. I have a bit of refactoring planned for the livecheck methods that should help improve the situation (albeit, after I get through some other livecheck work) but I can't say that I would miss these particular limits if they were removed.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Feb 21, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Feb 21, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurrah and good riddance 👋🏻

Thanks @issyl0!

@MikeMcQuaid MikeMcQuaid merged commit 98d9f28 into Homebrew:master Feb 21, 2023
@issyl0 issyl0 deleted the rubocop-disable-all-metrics branch February 21, 2023 09:33
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@issyl0 @BrewTestBot @samford @MikeMcQuaid