sorbet: Autogenerate the RBI file for utils/tty.rb

[issyl0]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

• Sort of. It's not via Parlour, because I read the docs and all it says about dynamically generating things is "of course it's better to do that", no examples. I tried my best, but Bo's work on attr.rb was mind-boggling.
• Instead, let's add a simple but functional generator script that I actually understand, as an alternative to maintaining these RBI files for dynamic methods manually, or as an alternative to skipping them entirely, so that we can get rid of some use of srb rbi hidden-definitions since that's deprecated.
• Follow up to sorbet: Convert some hidden-definitions into RBI files #14651.

---

• TODO (if this is the direction we want to go): Run this script as part of brew typecheck --update so it gets updated with all the other RBI files periodically.

• Feel free to throw this away if this isn't the direction we want to go or if it's rubbish and/or not the Proper Way - no hard feelings! ❤️

[BrewTestBot]

Review period will end on 2023-03-07 at 00:08:08 UTC.

[Bo98]

I tried my best, but Bo's work on attr.rb was mind-boggling.

Yes I agree.

The Parlour way makes sense on a technical sense as it's the way Sorbet does it - i.e. parsing an AST. However parsing AST is always not the easiest to understand. With Rubocop there's some AST stuff but we've built a few helper functions on top still.

An alternative way (i.e. like how Tapioca does it) would be runtime generation. It's sometimes a bit more "hacky" (i.e. for attr you would inject something that listens into attr_* as there's no way to get a list of attributes at runtime otherwise) but will in the end be easier to understand. I'll try rewrite attr.rb to do it that way soon which will hopefully mean it's more understandable by others.

The way you're doing here is not far off that so it makes sense to me, even as is.

[MikeMcQuaid]

• Run this script as part of brew typecheck --update so it gets updated with all the other RBI files periodically.

Agreed!

The way you're doing here is not far off that so it makes sense to me, even as is.

Good to know, happy to merge given that!

[BrewTestBot]

Review period ended.

[MikeMcQuaid]

Thanks again @issyl0!