Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ActiveSupport String inflections #14917

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Remove ActiveSupport String inflections #14917

merged 4 commits into from
Mar 8, 2023

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Mar 7, 2023 •
edited
Loading

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Relates to #10508

This removes ActiveSupport String inflections. The performance impact is minimal, bc most of the time was spent in requiring i18n, which remains as a transitive require (I prefer to pull these out one at a time).

@BrewTestBot
Copy link
Member

Review period will end on 2023-03-08 at 18:30:07 UTC.

@BrewTestBot BrewTestBot added the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 7, 2023
@dduugg dduugg changed the title String inflections Remove ActiveSupport String inflections Mar 7, 2023
dduugg
dduugg commented Mar 7, 2023
View reviewed changes
Library/Homebrew/test/utils_spec.rb
# ["HTTPAPI", "http_api"],
["HTTP::Get", "http/get"],
["SSLError", "ssl_error"],
# ["RESTful", "restful"],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these examples already don't work (trying them in brew irb on master), so this shouldn't be a breaking change, just highlighting where we aren't matching the ActiveSupport test suite.

@MikeMcQuaid MikeMcQuaid added the critical Critical change which should be shipped as soon as possible. label Mar 8, 2023
@BrewTestBot BrewTestBot removed the waiting for feedback Merging is blocked until sufficient time has passed for review label Mar 8, 2023
@BrewTestBot
Copy link
Member

Review period skipped due to critical label.

MikeMcQuaid
MikeMcQuaid approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @dduugg!

@MikeMcQuaid MikeMcQuaid enabled auto-merge March 8, 2023 12:39
@MikeMcQuaid MikeMcQuaid merged commit b180133 into Homebrew:master Mar 8, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dduugg @BrewTestBot @MikeMcQuaid