Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make manual installers easier to open. #15230

Merged
merged 1 commit into from
May 8, 2023

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Apr 14, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Allow easy copy-pasting to open the installer.

@reitermarkus reitermarkus force-pushed the installer-manual-open branch from 60f74bd to 16a9704 Compare April 14, 2023 18:15
@reitermarkus reitermarkus requested a review from a team April 14, 2023 18:19
@reitermarkus reitermarkus force-pushed the installer-manual-open branch from 16a9704 to 429e68e Compare April 16, 2023 21:55
@Bo98
Copy link
Member

Bo98 commented Apr 18, 2023

Just as a side note: a package manager that doesn't actually install some packages for you is a bit unusual to be honest. I assume this is sparingly used?

@reitermarkus reitermarkus force-pushed the installer-manual-open branch from 429e68e to df620ad Compare May 8, 2023 06:25
@reitermarkus reitermarkus requested a review from MikeMcQuaid May 8, 2023 07:25
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @reitermarkus!

@MikeMcQuaid MikeMcQuaid merged commit 63ad103 into Homebrew:master May 8, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants