Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Enable Sorbet by default for Homebrew developers and developer commands." #15368

Merged
merged 1 commit into from
May 5, 2023
Merged

Revert "Enable Sorbet by default for Homebrew developers and developer commands." #15368

merged 1 commit into from
May 5, 2023

Conversation

dawidd6
Copy link
Contributor

@dawidd6 dawidd6 commented May 5, 2023

@dawidd6 dawidd6 enabled auto-merge May 5, 2023 12:00
@dawidd6 dawidd6 added the critical Critical change which should be shipped as soon as possible. label May 5, 2023
@dawidd6 dawidd6 merged commit d2ea65a into master May 5, 2023
@dawidd6 dawidd6 deleted the revert-15326-more_sorbet_runtime branch May 5, 2023 12:16
This was referenced May 5, 2023
Merged
Closed
Closed
@MikeMcQuaid
Copy link
Member

@dawidd6 Can we make this revert more selective so disable the specific failing commands/configurations?

@dawidd6
Copy link
Contributor Author

dawidd6 commented May 5, 2023

@MikeMcQuaid I'm not sure, judging by the code brew readall should not have been affected by the Sorbet changes, yet looking at https://github.com/Homebrew/homebrew-core/actions/runs/4892972572/jobs/8735365498?pr=130235 proves otherwise 🤔.

@MikeMcQuaid
Copy link
Member

@dawidd6 I think the issue here is brew readall was just being excluded from developer commands but would still be run with Sorbet if HOMEBREW_DEVELOPER was set (which is is in homebrew-core).

@carlocab carlocab mentioned this pull request May 5, 2023
Merged
@carlocab
Copy link
Member

carlocab commented May 5, 2023

#15369

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dawidd6 @MikeMcQuaid @carlocab @BrewTestBot