Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #15369 from carlocab/sorbet-runtime" #15370

Merged
merged 1 commit into from
May 5, 2023
Merged

Revert "Merge pull request #15369 from carlocab/sorbet-runtime" #15370

merged 1 commit into from
May 5, 2023

Conversation

p-linnane
Copy link
Member

This reverts commit 8c059bb, reversing changes made to f71b3d3.

Fixes breakage starting dependent testing:

Run brew determine-test-runners --dependents --eval-all "$TESTING_FORMULAE"
Error: Return value: Expected type String, got type NilClass
Caller: /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/version.rb:627
Definition: /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/version.rb:655

@p-linnane
Revert "Merge pull request #15369 from carlocab/sorbet-runtime"
bcf94f6 
This reverts commit 8c059bb, reversing
changes made to f71b3d3.
@issyl0 issyl0 added the critical Critical change which should be shipped as soon as possible. label May 5, 2023
@issyl0 issyl0 merged commit c1fdb59 into Homebrew:master May 5, 2023
@p-linnane p-linnane deleted the sorbet-breakage branch May 5, 2023 17:31
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@issyl0 issyl0 issyl0 approved these changes

@BrewTestBot BrewTestBot BrewTestBot approved these changes

Assignees
No one assigned
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p-linnane @issyl0 @BrewTestBot