Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #15377 from carlocab/sorbet-runtime-take2" #15385

Merged
merged 1 commit into from
May 8, 2023
Merged

Revert "Merge pull request #15377 from carlocab/sorbet-runtime-take2" #15385

merged 1 commit into from
May 8, 2023

Conversation

p-linnane
Copy link
Member

@p-linnane p-linnane added the critical Critical change which should be shipped as soon as possible. label May 8, 2023
@EricFromCanada EricFromCanada enabled auto-merge May 8, 2023 19:19
@EricFromCanada EricFromCanada merged commit 3887829 into Homebrew:master May 8, 2023
@p-linnane p-linnane deleted the revert-sorbet-again branch May 8, 2023 19:34
@Bo98
Copy link
Member

Bo98 commented May 8, 2023

Once #15336 is merged, I'll go through and test everything I can before we enable this again (probably globally this time).

If you can open an issue noting each error you've seen that would be appreciated.

In particular, how we solve inreplace will be an interesting one. The original type signature seems correct, but backwards compatibility with formulae is the most important (either we just add Pathname or relax it further to T.untyped since duck typing is involved here really as anything with a to_s can be passed to it, which is really everything).

@p-linnane
Copy link
Member Author

The two examples in the body of this PR are the only ones I've seen this go around.

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
critical Critical change which should be shipped as soon as possible. outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants