Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/update-report: don't invoke external diff tools #15390

Merged
merged 1 commit into from
May 9, 2023
Merged

cmd/update-report: don't invoke external diff tools #15390

merged 1 commit into from
May 9, 2023

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented May 9, 2023

Fixes #15357.
Fixes #15386.

@reitermarkus
Copy link
Member

Would probably make sense to use this everywhere we use git diff.

MikeMcQuaid
MikeMcQuaid approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Bo98!

@MikeMcQuaid MikeMcQuaid merged commit b3f7c6f into Homebrew:master May 9, 2023
@Bo98 Bo98 deleted the update-report-no-ext-diff branch May 9, 2023 14:24
@github-actions github-actions bot added the outdated PR was locked due to age label Jun 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@reitermarkus reitermarkus reitermarkus approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

brew update hangs if global gitconfig defines external diff tool brew update displays external diff tool
3 participants
@Bo98 @reitermarkus @MikeMcQuaid