Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply cpu-optimisation to Rust projects #15544

Merged
merged 17 commits into from
Jul 4, 2023
Merged

Apply cpu-optimisation to Rust projects #15544

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
c344a3f
Apply cpu-optimisation to Rust projects (hardcoded)
Tokarak Jun 13, 2023
a072508
Revert "Apply cpu-optimisation to Rust projects (hardcoded)"
Tokarak Jun 13, 2023
066a888
Add rustflags_target_cpu method
Tokarak Jun 13, 2023
b4dd639
Use rustflags_target_cpu
Tokarak Jun 13, 2023
d4bfbb1
Remove FIXMEs
Tokarak Jun 13, 2023
2bd20ea
Fix
Tokarak Jun 13, 2023
c698174
Fix error on empty target-cpu
Tokarak Jun 13, 2023
cccad3e
Line break
Tokarak Jun 14, 2023
261f55a
Prepare to migrate to RUSTFLAGS
Tokarak Jun 14, 2023
2133da8
Set target-cpu through RUSTFLAGS
Tokarak Jun 14, 2023
9a99b93
Add RUSTFLAGS to ENV/super
Tokarak Jun 17, 2023
9a19f5b
Refactor to use oldest_cpu
Tokarak Jun 17, 2023
73c339d
Style changes
Tokarak Jun 17, 2023
40aa419
More cpus in rust_optimisation_flags
Tokarak Jun 17, 2023
87158ac
Improve logic (code review)
Tokarak Jun 20, 2023
55bdbab
brew style --fix
Tokarak Jun 20, 2023
521fdcb
Wording
Tokarak Jun 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Library/Homebrew/formula.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,11 @@ def std_configure_args
# Standard parameters for cargo builds.
sig { params(root: T.any(String, Pathname), path: String).returns(T::Array[T.any(String, Pathname)]) }
def std_cargo_args(root: prefix, path: ".")
["--locked", "--root", root, "--path", path]
["--locked", "--root", root, "--path", path,
"--config", "target.x86_64-apple-darwin.rustflags=['-Ctarget-cpu=nehalem']",
"--config", "target.aarch64-apple-darwin.rustflags=['-Ctarget-cpu=apple-m1']",
Tokarak marked this conversation as resolved.
Show resolved Hide resolved
# Default target-cpu is apple-m1 since Rust 1.71.0
]
end

# Standard parameters for CMake builds.
Expand Down