Narrow member type of inreplace paths enumerable #15800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
approved these changes
Aug 1, 2023
dduugg
commented
Aug 1, 2023
| after &&= after.to_s | ||
| before = before.to_s if before.is_a?(Pathname) | ||
|
|
||
| errors = {} | ||
|
|
||
| errors["`paths` (first) parameter"] = ["`paths` was empty"] if paths.blank? |
There was a problem hiding this comment.
Some slight logic change to account for the fact that Enumerable doesn't necessarily define blank?. This is technically more strict ([''] would previously have been ok), but i believe to be semantically correct.
| @@ -39,21 +39,22 @@ def initialize(errors) | |||
| # @api public | |||
| sig { | |||
| params( | |||
| paths: T.any(T::Array[T.untyped], String, Pathname), | |||
| paths: T.any(T::Enumerable[T.any(String, Pathname)], String, Pathname), | |||
There was a problem hiding this comment.
I believe this needs be widened to allow the super call in the Formula implementation (although sorbet didn't complain).
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?As suggested in #15796 (comment)
cc @carlocab @MikeMcQuaid