Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/brew: avoid eval and grep #15821

Merged
merged 1 commit into from
Aug 4, 2023
Merged

bin/brew: avoid eval and grep #15821

merged 1 commit into from
Aug 4, 2023

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Aug 4, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

eval is a much bigger hammer than we need here, so let's try to avoid
that.

Also, we can use the builtin read instead of shelling out to grep
which will be slightly more efficient.

`eval` is a much bigger hammer than we need here, so let's try to avoid
that.

Also, we can use the builtin `read` instead of shelling out to `grep`
which will be slightly more efficient.
@MikeMcQuaid MikeMcQuaid enabled auto-merge August 4, 2023 14:03
@MikeMcQuaid
Copy link
Member

Looks great, nice work!

@MikeMcQuaid MikeMcQuaid merged commit 75a1948 into Homebrew:master Aug 4, 2023
@carlocab carlocab deleted the no-eval-grep branch August 4, 2023 14:26
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants