utils/curl: include or use explicitly. #15940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I remember trying this a few months ago but gave up once I realized how many little changes would be necessary. Good luck! |
MikeMcQuaid
changed the title
Include or use `Utils::Curl` explicitly everywhere it is used.
|
This might need updating: https://github.com/Homebrew/actions/blob/41775cf0c82ef066f1eb39cea1bd74697ca5b735/review-cask-pr/review.rb#L17 (though it probably shouldn't be using private API) |
Bo98
approved these changes
Sep 5, 2023
@Bo98 Done, good catch and thanks for review! |
MikeMcQuaid
added a commit
to Homebrew/actions
that referenced
this pull request
Sep 5, 2023
This will be required after Homebrew/brew#15940 is merged.
|
@MikeMcQuaid I am seeing this error in Cask: Seen in Homebrew/homebrew-cask#154437 and Homebrew/homebrew-cask#154438 |
ZhongRuoyu
added a commit
to ZhongRuoyu/brew
that referenced
this pull request
Sep 5, 2023
Needed after Homebrew#15940.
ZhongRuoyu
added a commit
to ZhongRuoyu/brew
that referenced
this pull request
Sep 5, 2023
Needed after Homebrew#15940.
ZhongRuoyu
added a commit
to ZhongRuoyu/brew
that referenced
this pull request
Sep 5, 2023
Needed after Homebrew#15940.
ZhongRuoyu
added a commit
to ZhongRuoyu/brew
that referenced
this pull request
Sep 5, 2023
Needed after Homebrew#15940.
dduugg
pushed a commit
to dduugg/brew
that referenced
this pull request
Sep 30, 2023
dduugg
pushed a commit
to dduugg/brew
that referenced
this pull request
Sep 30, 2023
dduugg
pushed a commit
to dduugg/brew
that referenced
this pull request
Sep 30, 2023
Needed after Homebrew#15940.
dduugg
pushed a commit
to dduugg/brew
that referenced
this pull request
Sep 30, 2023
Needed after Homebrew#15940.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include or use
Utils::Curlexplicitly everywhere it is used.