workflows/build-pkg: tweak some variables. #16071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMillerDev
approved these changes
Oct 2, 2023
MikeMcQuaid
force-pushed
the
pkg_tweaks
branch
from
3aca477 to
c2635eb
Compare
- instead of setting a static `PKG_KEYCHAIN_PASSWORD` secret, generate a random password from `openssl rand` instead. - use `PKG_APPLE_ID_EMAIL` which makes the fact it's an email a bit more obvious. I've created this new secret already and will delete the old one after this is merged. - bump the latest supported version of macOS
MikeMcQuaid
force-pushed
the
pkg_tweaks
branch
from
c2635eb to
def7ab4
Compare
|
Known disruptive tests have failed for this pull request. Commit SHA: b855a9e
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKG_KEYCHAIN_PASSWORDsecret, generate a random password fromopenssl randinstead.PKG_APPLE_ID_EMAILwhich makes the fact it's an email a bit more obvious. I've created this new secret already and will delete the old one after this is merged.brew.shto point to this.