Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the GitHub link that is generated when the required scope of the token has mismatched with the present scope #16633

Conversation

sohanh
Copy link
Contributor

@sohanh sohanh commented Feb 9, 2024

Improved the GitHub link that is generated when the required scope of the token has mismatched with the present scope

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

… the token has mismatched with the present scope
@reitermarkus
Copy link
Member

Thanks, @sohanh!

@reitermarkus reitermarkus merged commit 8b69b89 into Homebrew:master Feb 10, 2024
24 checks passed
@sohanh
Copy link
Contributor Author

sohanh commented Feb 10, 2024

thanks @reitermarkus you are awesome

@MikeMcQuaid
Copy link
Member

Great work here, thanks @sohanh and @reitermarkus!

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants