internal json v3: parse ruby source checksum correctly #16768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we are including this in the API but not actually parsing and loading it correctly from the JSON. I think this was an oversight when addressing feedback and refactoring the JSON shape. Not a big deal, of course, because I'm the only person using it right now. I found this out while testing installs using the API and I got this error while running `brew reinstall tree`. ``` Warning: Cannot verify integrity of '60fc4212023d3fef00e6de4b9f3f0d63402cf3eca00778d09f4f2d3481b524a1--tree.rb'. No checksum was provided. ```
|
Related to #16638 |
MikeMcQuaid
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?Currently we are including this in the API but not actually parsing and loading it correctly from the JSON. I think this was an oversight when addressing feedback and refactoring the JSON shape. Not a big deal, of course, because I'm the only person using it right now.
I found this out while testing installs using the API and I got this error while running
brew reinstall tree.I also am excluding the
HOMEBREW_INTERNAL_JSON_V3environment variable from tests because it was causing some API loading tests to fail.