Fix loading casks/formulae from relative paths.

[reitermarkus]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

I don't think there is a way to match everything except ./.. using a regex, so this adds two new methods to convert a tapped name (e.g. homebrew/core/gcc) into a pair of tap and name, matching all tapped names except those that look like relative paths, e.g. ./Formula/gcc.rb.

Fixes #16773.

[apainintheneck]

I don't think there is a way to match everything except ./.. using a regex, so this adds two new methods to convert a tapped name (e.g. homebrew/core/gcc) into a pair of tap and name, matching all tapped names except those that look like relative paths, e.g.

Do we support periods in full tap name? If not, we could just update the regexes to ignore entries that have periods in the repo or user sections of the tapped name.

[MikeMcQuaid]

Thanks for quick turnaround here @reitermarkus! ❤️

Merging this ASAP to fix user issue but, in hindsight, I really wish we'd just left these regex alone instead of causing multiple user issues.

Please let's try to be more minimal and conservative with additional refactoring, thanks 🙇🏻

[reitermarkus]

Do we support periods in full tap name?

Yes, we just weren't using these regexes consistently in Formulary, and e.g. Tap::fetch still does not validate the tap name in the same way currently.

I really wish we'd just left these regex alone instead of causing multiple user issues.

The regexes were silently broken for years, this had to surface at some point. Ideally we should just get rid of these regexes, as I think we now only have one usage of each outside of Tap.

[MikeMcQuaid]

The regexes were silently broken for years, this had to surface at some point. Ideally we should just get rid of these regexes, as I think we now only have one usage of each outside of Tap.

Sorry, "silently broken" but not causing users to file issues about things is definitely superior to "fixed" but breaking things for multiple users in multiple places.

Refactors like this are not worth it when they break things for actual users.