Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nil repositories in dev-cmd bump #16926

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Fix nil repositories in dev-cmd bump #16926

merged 1 commit into from
Mar 20, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Mar 20, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Should resolve: https://github.com/Homebrew/homebrew-core/actions/runs/8364009822/job/22898307196#step:6:27

Possible regression: https://github.com/Homebrew/brew/pull/16887/files#diff-8d9528218ff2999bae098a7ce1556f42c61d546b285fa962ee62a8b2a35e9901R156

(Another option would be to widen the type signatures, which I prefer to avoid. That may be more semantically correct though, idk.)

@dduugg dduugg requested a review from Bo98 March 20, 2024 20:42
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't that commit that regressed it because it was always conditionally nil but I agree nil arrays suck and this is better.

@Bo98 Bo98 enabled auto-merge March 20, 2024 20:45
@Bo98 Bo98 merged commit fe35b94 into master Mar 20, 2024
23 checks passed
@Bo98 Bo98 deleted the nilable-bump-repositories branch March 20, 2024 20:53
@MikeMcQuaid
Copy link
Member

Thanks for quick turnaround here @dduugg and @Bo98!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants