formula_installer: handle nil runtime dependencies #16952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Some old bottles (Sierra and earlier) will fail to install when the downloaded bottle manifest has its
runtime_dependencies
set tonull
rather than[]
. This happens during manifest generation whenTab
finds the tab'shomebrew_version
to be either not present or earlier than 1.1.6. The existingfetch_bottle_tab
method passes an empty list ifruntime_dependencies
is not present; this change ensures that the same happens ifruntime_dependencies
is present butnil
.Also,
Tab#runtime_dependencies
could return an empty list ifhomebrew_version
< 1.1.6 to avoid this in future manifests. Not sure if that's necessary.Before:
After: