Output version upgrade info using puts
#16959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This PR changes the two-line upgrade message to use
puts
for the second line (oh1
is still used for the first line). This prevents version numbers from being truncated when upgrading formulae, which can happen if a formula has a very long name or is in a non-core tap. More info is at #16942 and this comment on that issue.I attempted to write a test for this, but I have not been successful. This is my attempted test (for inclusion in cmd/upgrade):
The problem I’m having is that
$stdout.tty?
doesn’t seem to returntrue
, so no messages are truncated here (because$stdout.tty?
is actuallyfalse
):Consequently, this test is passing currently (that is, without the changes in this PR), so I left this test out.