Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate_disable: add cask deprecation reason #16960

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

bevanjkay
Copy link
Member

@bevanjkay bevanjkay commented Mar 27, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Adds an additional deprecate!/disable! reason for casks, for when an app moves to the Mac App Store.
Would be used for Homebrew/homebrew-cask#170096 and other similar circumstances.

@apainintheneck
Copy link
Contributor

How often does this happen?

@bevanjkay
Copy link
Member Author

I'm not sure exactly, but I would say common enough (5+ a year) to warrant it being a listed reason.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @bevanjkay!

@MikeMcQuaid MikeMcQuaid merged commit b63334c into Homebrew:master Mar 28, 2024
25 checks passed
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants