keg: mkpath while linking {include,lib,share}/postgresql@X
#16966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?I think this will make it easier to retain extensions on different PostgreSQL.
citus
, for example, installs files like:include/postgresql@14/server/citus_version.h
lib/postgresql@14/citus.so
share/postgresql@14/extension/citus--10.0-1--10.0-2.sql
Reasoning here is we may need to manually link some
keg_only
files/dirs inside the post install ofpostgresql@X
formulae; however, if another formula already created symlink paths then it will make things complicated.I guess some other alternatives would be:
keg.link_dir
logic that does all the symlink-to-real-directory conversion. However,Keg
is@api private
and we may not want to change this.brew/Library/Homebrew/keg.rb
Line 618 in c3094ac
keg_only
DSL to allow "partial"keg_only
. Con here is this will require various code modifications (across link code, DSL, JSON API, etc) for something that may only be useful for PostgreSQL.