cleanup: fix various cases where cache wasn't being removed properly

[Bo98]

• utils/bottles: fix outdated bottle check
  • This check was completely broken under GitHub Packages as it would compare a classic formula bottle file extension to a ghcr.io url which just contains a sha256 string.
  • Now properly compares tag and rebuild.
• cleanup: better handle version_scheme scenarios
  • When version_scheme is bumped, formula.version > version will not be true. We cannot extract the version scheme here, but we can special case the latest-version-installed case to make that != which should cover most scenarios.
• cleanup: better support bottle manifests
  • brew cleanup <formula> failed to check any associated bottle manifests and those would only ever be removed by the timed prune.
  • This is now supported under the stale check by removing the _bottle_manifest suffix when parsing the formula name.

Will probably make a tag with this given it's causing some confusion/concern.

[apainintheneck]

Would it be possible to add regression tests for these bugs?

[apainintheneck]

Suggested change

	file = file.resolved_path
	filename = file.basename.to_s
	return false if formula.bottle.blank?
	return false if formula.bottle.blank?
	file = file.resolved_path
	filename = file.basename.to_s

Nit: Avoid extra work if the bottle doesn't exist.

[MikeMcQuaid]

Great work @Bo98!

Agreed regression tests would be nice but don't want this to be blocked on that for the tag tomorrow.

[lembacon]

This seems introducing a regression that may aggressively cleanup cached bottle downloads when bottles were ever rebuilt.

For example, with latest ncurses-6.4 and the bottle of which has a rebuild of 1, brew install ncurses && brew cleanup will immediately removed the cached bottle and manifest that have just been downloaded.

[Bo98]

Probably the first commit. Rebuilds were previously never removed because it was completely broken. It's possible that the original intended behaviour is now slightly too aggressive or I missed an edge case. Will check your example.

[Bo98]

Can't reproduce the cached bottle part but have reproduced the manifest issue and have fixed: #16992

[lembacon]

Actually it seems also related to the formula's revision.

I just tried brew reinstall glib && brew cleanup -n, it would remove both the downloaded bottle and manifest.

[lembacon]

It turns out that #16992 also resolves the issue for formulae with non-default revision, i.e. glib. 🥳

[MikeMcQuaid]

@lembacon Thanks for reporting and testing 🎉

[Bo98]

Ah yeah that makes sense if it's glib rather than ncurses. Weren't using pkg_version properly before but we now are!