Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FromContentLoader.try_new typesafe #18019

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Make FromContentLoader.try_new typesafe #18019

merged 2 commits into from
Aug 12, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Aug 11, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Just a tiny fix to improve type safety. This passes tests, it should work in the wild, if the class docstring is accurate…

apainintheneck
apainintheneck previously approved these changes Aug 12, 2024
@apainintheneck apainintheneck dismissed their stale review August 12, 2024 01:56

I misunderstood the code.

@apainintheneck apainintheneck added the cask Homebrew Cask label Aug 12, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @dduugg! Given how often these signatures sadly go 💥: let's hold off until after the next tag (which will be later today UK time, merge Tuesday UK time?)

@MikeMcQuaid MikeMcQuaid merged commit 6b3cac7 into master Aug 12, 2024
24 checks passed
@MikeMcQuaid MikeMcQuaid deleted the safe-try-new branch August 12, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cask Homebrew Cask
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants