Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_config: print brew branch #18811

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Nov 24, 2024

When debugging others' problems (or even one's own), it helps to know which branch brew itself is on, to avoid unwarranted assumptions that lead to a wild goose chase. (Been there, done that, facepalmed more than once.)

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gromgit! Good idea, just think we'll tweak slightly before merge.

Library/Homebrew/system_config.rb Outdated Show resolved Hide resolved
@gromgit gromgit changed the title system_config: print brew branch if not on master system_config: print brew branch Nov 25, 2024
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gromgit!

@MikeMcQuaid MikeMcQuaid merged commit 666601f into Homebrew:master Nov 25, 2024
28 checks passed
@gromgit gromgit deleted the brew-branch branch November 25, 2024 15:19
@Homebrew Homebrew deleted a comment from Zuleima1464 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants