-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable strict typing in NamedArgs #18867
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dduugg
commented
Dec 4, 2024
MikeMcQuaid
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me when 🟢! Please be around for a bit after merging in case there's type-related regressions.
dduugg
commented
Dec 4, 2024
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-aliases
that referenced
this pull request
Dec 7, 2024
This fixes the typecheck issues due to Homebrew/brew#18867. The logic is also refactored to make it hopefully easier to understand than before. This also fixes the issue where the plain `brew alias` command would not print anything due to incorrect usage of `Aliases.show`.
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-aliases
that referenced
this pull request
Dec 7, 2024
This fixes the typecheck issues due to Homebrew/brew#18867. The logic is also refactored to make it hopefully easier to understand than before. This also fixes the issue where the plain `brew alias` command would not print anything due to incorrect usage of `Aliases.show`.
ZhongRuoyu
added a commit
to ZhongRuoyu/homebrew-aliases
that referenced
this pull request
Dec 7, 2024
This fixes the typecheck issues due to Homebrew/brew#18867. The logic is also refactored to make it hopefully easier to understand than before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?typed: strict
in all (non-package) files in Homebrew organisation #17297(I also grouped the private methods together, which is the bulk of the second commit, for ease of review.)
The code is sometimes a bit loose with conflating
Keg
s withFormula
. I chose the path of least refactor where that came up, but it might create some hiccups as we roll this out.