Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict typing in NamedArgs #18867

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Enable strict typing in NamedArgs #18867

merged 2 commits into from
Dec 4, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Dec 4, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

(I also grouped the private methods together, which is the bulk of the second commit, for ease of review.)

The code is sometimes a bit loose with conflating Kegs with Formula. I chose the path of least refactor where that came up, but it might create some hiccups as we roll this out.

Library/Homebrew/cli/named_args.rb Show resolved Hide resolved
Library/Homebrew/cli/named_args.rb Show resolved Hide resolved
Library/Homebrew/cmd/info.rb Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me when 🟢! Please be around for a bit after merging in case there's type-related regressions.

@dduugg dduugg enabled auto-merge December 4, 2024 16:48
@dduugg dduugg merged commit ad70bcb into master Dec 4, 2024
28 checks passed
@dduugg dduugg deleted the typed-named-args branch December 4, 2024 16:49
ZhongRuoyu added a commit to ZhongRuoyu/homebrew-aliases that referenced this pull request Dec 7, 2024
This fixes the typecheck issues due to Homebrew/brew#18867. The logic is
also refactored to make it hopefully easier to understand than before.

This also fixes the issue where the plain `brew alias` command would not
print anything due to incorrect usage of `Aliases.show`.
ZhongRuoyu added a commit to ZhongRuoyu/homebrew-aliases that referenced this pull request Dec 7, 2024
This fixes the typecheck issues due to Homebrew/brew#18867. The logic is
also refactored to make it hopefully easier to understand than before.

This also fixes the issue where the plain `brew alias` command would not
print anything due to incorrect usage of `Aliases.show`.
ZhongRuoyu added a commit to ZhongRuoyu/homebrew-aliases that referenced this pull request Dec 7, 2024
This fixes the typecheck issues due to Homebrew/brew#18867. The logic is
also refactored to make it hopefully easier to understand than before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants