Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: enforce super in lifecycle hooks #1888

Merged
merged 1 commit into from
Jan 21, 2017

Conversation

alyssais
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Made all existing setup and teardown methods call super, and added a LifecycleEnforcer test plugin that will enforce this for new tests.

This will allow us to have global setup and teardown for tests.

For example, we can automatically clear caches after each test, to avoid annoying intermittent failures like #1879 and #1886.

This will allow us to have global setup and teardown for tests.

For example, we can automatically clear caches after each test, to avoid
annoying intermittent failures like Homebrew#1879 and Homebrew#1886.
@alyssais alyssais force-pushed the tests_enforce_lifecycle branch from 1daa66f to 70a381a Compare January 21, 2017 11:34
@MikeMcQuaid
Copy link
Member

Great work. Feels like the best solution.

@alyssais alyssais merged commit ab9d8df into Homebrew:master Jan 21, 2017
@alyssais alyssais deleted the tests_enforce_lifecycle branch January 21, 2017 13:24
@Homebrew Homebrew locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants