Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor CLI code improvements #18902

Merged
merged 1 commit into from
Dec 8, 2024
Merged

Minor CLI code improvements #18902

merged 1 commit into from
Dec 8, 2024

Conversation

dduugg
Copy link
Member

@dduugg dduugg commented Dec 7, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Extracts unrelated updates from #18847 by request:

  • Move error classes to a dedicated file
  • Replace cli_args with a more idiomatic ruby implementation

@dduugg dduugg merged commit 8fa9b72 into master Dec 8, 2024
28 checks passed
@dduugg dduugg deleted the cli-cleanup branch December 8, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants