dev-cmd/tap-new: improve handling of multi-user setups #18909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
approved these changes
Dec 10, 2024
MikeMcQuaid
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew largely operates under the model where EUID == Homebrew owner (proxy) and UID == requesting user.
This cross-user model doesn't really work well with
brew tap-newwhich does git commits. This PR fixes it so that it can read the author information of the requesting user.Known issue (that realistically won't be fixed): on macOS, this will not work with Xcode 14.0 through 14.2. On Linux (or I guess old Homebrew Git installs on macOS too potentially) this will not work with any (potentially distro-patched) system Git <2.39 that have the safe directory changes but didn't backport
-c safe.directorysupport. This however isn't a regression from the previous state where it still didn't work anyway, and can be fixed by using Homebrew git.